Use bootclasspath jar in proguard genrule #23067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, proguard may attempt to access the Java runtime jmods, which aren't declared as inputs.
github-actions
bot
added
the
awaiting-review
|
@werkt Could you verify that this fixes the issue for you? |
meteorcloudy
approved these changes
Jul 23, 2024
meteorcloudy
added
awaiting-PR-merge
This checks out. Thanks for the speedy fix. CI could use some remote execution, I'll have to check to see if this gets a positive result with bazel-remote or something similar to be embedded. |
werkt
approved these changes
Jul 23, 2024
sgowroji
added
the
team-OSS
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 7.4.0 |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 22, 2024
Previously, proguard may attempt to access the Java runtime jmods, which aren't declared as inputs. Fixes bazelbuild#22787 (comment) Closes bazelbuild#23067. PiperOrigin-RevId: 655470599 Change-Id: I5ff6cd9c32f553fc3d8364ba1b6a4f4e3417418b
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 23, 2024
Cherry-picks of: * Strip unnecessary Bazel server jar contents (bazelbuild#22787) * Use bootclasspath jar in proguard genrule (bazelbuild#23067) Closes bazelbuild#23707 Closes bazelbuild#23708
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, proguard may attempt to access the Java runtime jmods, which aren't declared as inputs.
Fixes #22787 (comment)